Skip to content

feat: editor: hint matches for matchLabels/-Expressions & list them in dialog (#642) #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

feat: editor: hint matches for matchLabels/-Expressions & list them in dialog (#642) #858

merged 1 commit into from
May 13, 2025

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Mar 10, 2025 •
edited
Loading

fixes #642

@adietish adietish self-assigned this Mar 10, 2025
@adietish adietish force-pushed the issue-642 branch 16 times, most recently from 9294831 to aba2406 Compare March 25, 2025 16:02
@adietish adietish force-pushed the issue-642 branch 8 times, most recently from 56c98a0 to ce365fd Compare March 31, 2025 21:27
@adietish adietish force-pushed the issue-642 branch 4 times, most recently from 587d481 to 93503a4 Compare April 5, 2025 22:36
@adietish adietish force-pushed the issue-642 branch 3 times, most recently from c9b2dd1 to e8f76cf Compare April 12, 2025 22:31
@adietish adietish requested a review from btjd April 14, 2025 11:12
@adietish adietish force-pushed the issue-642 branch 8 times, most recently from 8b6b043 to ad2eb27 Compare April 14, 2025 21:46
@adietish adietish marked this pull request as ready for review April 16, 2025 13:38
@adietish adietish force-pushed the issue-642 branch 2 times, most recently from 9355acf to 73001e8 Compare April 27, 2025 19:58
@adietish
Copy link
Collaborator Author

@btjd please review, thanks!

@adietish adietish changed the title feat: hint ref'd by matchLabels/-Expressions & list them in editor (#642) feat: editor: hint matches for matchLabels/-Expressions & list them in dialog (#642) Apr 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adietish adietish requested review from sbouchet and removed request for btjd April 28, 2025 15:40
@adietish
Copy link
Collaborator Author

@sbouchet: reviewed usage with @btjd, would be great if you could test this and review the code. I'll give Muthu the other 2 issues for reviewing. Thanks!

@adietish adietish mentioned this pull request Apr 28, 2025
Merged
sbouchet
sbouchet approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice new feature !
I've tested multi document references labels and also single document references, all working great !

@adietish
Copy link
Collaborator Author

@sbouchet: awesomeness, thanks for testing!

@adietish adietish merged commit bea4995 into redhat-developer:main May 13, 2025
9 of 10 checks passed
@adietish adietish deleted the issue-642 branch May 13, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I'd like to be able to navigate from selector labels/expressions to matching labels
2 participants
@adietish @sbouchet